Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(html-in-js): do not break empty content #5355

Merged
merged 3 commits into from Nov 7, 2018
Merged

fix(html-in-js): do not break empty content #5355

merged 3 commits into from Nov 7, 2018

Conversation

ikatyang
Copy link
Member

@ikatyang ikatyang commented Nov 6, 2018

This one should be the final fix in 1.15.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang added this to the 1.15 milestone Nov 6, 2018
lipis
lipis approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@lipis lipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@lipis
Copy link
Member

lipis commented Nov 6, 2018

🐑 it :)

@j-f1
Copy link
Member

j-f1 commented Nov 6, 2018

IMO html`` should never break. Perhaps check if the content is empty and print the backticks together in that case?

@ikatyang ikatyang merged commit 40ac851 into prettier:master Nov 7, 2018
@ikatyang ikatyang deleted the fix/html/multiparser-js-html branch November 7, 2018 00:32
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lipis lipis lipis approved these changes

@duailibe duailibe duailibe approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ikatyang @lipis @j-f1 @duailibe