Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsx): do not move trailing char to the next line as leading char #5354

Merged
merged 3 commits into from Nov 6, 2018
Merged

fix(jsx): do not move trailing char to the next line as leading char #5354

merged 3 commits into from Nov 6, 2018

Conversation

ikatyang
Copy link
Member

@ikatyang ikatyang commented Nov 6, 2018

Fixes #5336

Though I'm not sure why we should special-case self-closing tags, the changes look OK to me.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang merged commit a4e8aaf into prettier:master Nov 6, 2018
@ikatyang ikatyang deleted the fix/jsx/jsx-line-break branch November 6, 2018 23:41
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@duailibe duailibe duailibe approved these changes

@j-f1 j-f1 j-f1 approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ikatyang @duailibe @j-f1