Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language support docs #5178

Merged
merged 3 commits into from Nov 6, 2018
Merged

Update language support docs #5178

merged 3 commits into from Nov 6, 2018

Conversation

timup
Copy link
Contributor

@timup timup commented Oct 2, 2018

This commit updates docs language to reflect the change in #4528 that removes the inferred default parser.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

This commit updates docs language to reflect the change in prettier#4528 that removes the inferred default parser.
@lydell
Copy link
Member

lydell commented Oct 2, 2018

Hmm, actually, does this file provide any useful information at all? I'd say we remove it.

@timup
Copy link
Contributor Author

timup commented Oct 2, 2018

Not especially, as the same information is available in /docs/options.md

@j-f1
Copy link
Member

j-f1 commented Oct 3, 2018

Should we keep the part about the Flow test suite somewhere?

@lydell
Copy link
Member

lydell commented Oct 3, 2018

No, I don't think so. It was important when Prettier was new an untested, but not so much anymore. It's not even entirely true anymore (Prettier supports all Flow features, but tests/flow does not contain the entire Flow test suite anymore).

@lipis
Copy link
Member

lipis commented Nov 4, 2018

So shall we remove it or what?

@lipis
Copy link
Member

lipis commented Nov 4, 2018

I say we kill it with fire!

@duailibe
Copy link
Member

duailibe commented Nov 5, 2018

@timup Do you want to update the PR removing the file?

@j-f1
Copy link
Member

j-f1 commented Nov 5, 2018

IMO the facts that we require a minimum TS version and support all JS proposed features should be kept somewhere.

This removes the language support doc file as information is out dated, or available elsewhere in the docs.
@duailibe duailibe merged commit f9bce75 into prettier:master Nov 6, 2018
@duailibe
Copy link
Member

duailibe commented Nov 6, 2018

Thank you @timup!

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants