Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap awaits in unary expressions with parens #4315

Merged
merged 1 commit into from Apr 14, 2018

Conversation

ZachGawlik
Copy link
Contributor

@ZachGawlik ZachGawlik commented Apr 14, 2018

Fixes #4138 by wrapping await expressions inside of unary expressions. (list of unary operators)

Sample input (currently prettier would leave this unchanged):

const w = !await resolveIdentity(false);
const x = -await resolveIdentity(3);
const y = +await resolveIdentity('3');
const z = typeof await resolveIdentity(false);

Output:

const w = !(await resolveIdentity(false));
const x = -(await resolveIdentity(3));
const y = +(await resolveIdentity('3'));
const z = typeof (await resolveIdentity(false));

Copy link
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite a bit clearer 👍

Copy link
Member

@lydell lydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this too!

@j-f1 j-f1 merged commit 0a22f5e into prettier:master Apr 14, 2018
@j-f1
Copy link
Member

j-f1 commented Apr 14, 2018

Thanks!

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 13, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

negate async function result will break in safari 11
4 participants