fix(schema): support array type #4312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-f1
requested changes
Apr 13, 2018
scripts/generate-schema.js
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| "use strict"; | |||
|
|
|||
| if (process.env.NODE_ENV === "test") { | |||
| if (process.env.NODE_ENV === "test" || process.env.CI) { | |||
There was a problem hiding this comment.
What about using if (requre.main === module) as the condition (more info on Stack Overflow), and inverting the two blocks?
This way, you can still require() the module outside of CI/tests.
duailibe
approved these changes
Apr 13, 2018
j-f1
approved these changes
Apr 13, 2018
lipis
approved these changes
Apr 14, 2018
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to take
option.arrayinto account.