refactor: parseNestedCSS function
#4208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
commented
Mar 26, 2018
| @@ -357,7 +357,7 @@ $KeepScssVar: val; | |||
| .Keep(); | |||
| .Keep(4px) !important; | |||
| .Keep() when (@Keep=Keep); | |||
| .Keep() when (@Keep=12px); | |||
| .Keep() when (@Keep=12PX); | |||
There was a problem hiding this comment.
In last LESS version value case sensitivity, let's output as is
alexander-akait
commented
Mar 26, 2018
| @@ -1303,20 +1303,20 @@ $var: /* comment 1 */ all /* comment 2 */ !default /* comment 3 */ ; /* comment | |||
| /* comment 20 */ | |||
| } | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| $var: /* comment 1 */ all /* comment 2 */ !default /* comment 3 */ ; /* comment 4 */ | |||
| $var: /* comment 1 */ all /* comment 2 */ !default /* comment 3 */; /* comment 4 */ | |||
There was a problem hiding this comment.
Better output comments in value properties
alexander-akait
commented
Mar 26, 2018
| .desktop-and-old-ie({ | ||
| background-color: red; | ||
| }); | ||
| .desktop-and-old-ie({background-color: red;}); |
There was a problem hiding this comment.
We use postcss-selector-parser and it is can break code. We should use postcss-value-parser for this. I can do this in other PR.
alexander-akait
force-pushed
the
refactor-parse-nested-CSS
branch
from
952ee57
to
32c565c
Compare
lydell
approved these changes
Apr 13, 2018
duailibe
approved these changes
Apr 13, 2018
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve speed and fix places where we can break code