Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vue self-closing tags #3705

Merged
merged 3 commits into from
Jan 10, 2018
Merged

Fix vue self-closing tags #3705

merged 3 commits into from
Jan 10, 2018

Conversation

duailibe
Copy link
Member

@duailibe duailibe commented Jan 10, 2018 •
edited

Closes #3702

/cc @vjeux @azz

@vjeux
Copy link
Contributor

vjeux commented Jan 10, 2018

Can you make sure that all the hacks @azz put in place have been removed?

https://github.com/prettier/prettier/pull/3693/files

Thanks!

vjeux
vjeux approved these changes Jan 10, 2018
View reviewed changes
Copy link
Contributor

@vjeux vjeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We should do a minor release with this.

@duailibe
Copy link
Member Author

Only thing I didn't revert was the new line added in the end

@duailibe duailibe merged commit 46baad0 into prettier:master Jan 10, 2018
@duailibe duailibe deleted the vue-self-closing branch January 10, 2018 19:41
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@vjeux vjeux vjeux approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@duailibe @vjeux @existentialism