Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore whitespace in docblock right after /** #3430

Merged
merged 1 commit into from Dec 7, 2017

Conversation

duailibe
Copy link
Member

@duailibe duailibe commented Dec 7, 2017

A whitespace right after /** is parsed as the docblock comment. Initially I thought we should report this to jest, but I'm not sure this is a bug in jest and since we already strip leading new lines it seemed better we handle this case here.

Fixes #3426

(cc @SimenB, @vjeux)

Copy link
Contributor

@vjeux vjeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@duailibe duailibe merged commit 90e8b13 into prettier:master Dec 7, 2017
@duailibe duailibe deleted the docblock-spaces branch December 7, 2017 05:28
@duailibe duailibe added this to the 1.9.2 milestone Dec 10, 2017
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants