Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Optional Spaces Removed From JSX #30

Closed
pablosichert opened this issue Jan 10, 2017 · 2 comments
Closed

Non-Optional Spaces Removed From JSX #30

pablosichert opened this issue Jan 10, 2017 · 2 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:bug Issues identifying ugly output, or a defect in the program

Comments

@pablosichert
Copy link

For

<span>
    foo <span>bar</span>
</span>

I got

<span>
  foo<span>bar</span>
</span>;

which would render foo bar vs foobar.


Thanks for the great tool, though! Hope to adopt it once it becomes stable 馃尀

@jlongster
Copy link
Member

Good catch, thanks. We try to format JSX when we can help, which is why the indentation before foo is changed, but we certainly shouldn't remove this space.

@jlongster jlongster mentioned this issue Jan 10, 2017
@vramana vramana added the type:bug Issues identifying ugly output, or a defect in the program label Jan 11, 2017
@vramana vramana mentioned this issue Jan 11, 2017
11 tasks
@vramana
Copy link

vramana commented Jan 11, 2017

Closing this in favour of #73

@vramana vramana closed this as completed Jan 11, 2017
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 8, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
Development

No branches or pull requests

3 participants