New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boilerplate/CLI outreach #2886
Comments
create-react-app seems like an obvious first choice to me. |
I think formatting everything would be too obtrusive for CRA, but I could see bundling it with the require pragma option |
I only looked at vue cli (with the webpack template) and CRA. They both use a webpack loader for ESLint. Should we support something like that? |
@duailibe can the webpack loader use Inclusion in |
Looks like you can: https://github.com/MoOx/eslint-loader#fix-default-false |
One thing to keep in mind with some of these boilerplates and CLIs is that they're designed for beginners. If Prettier is enforced in an eslint workflow, it becomes another tool the beginner needs to learn before making their app. I can imagine someone:
Perhaps encouraging Prettier to be recommended, but opt-in in these tools would be the best course of action. |
Awesome. I might be able to submit a PR for that in a couple weeks, but if someone else can do it that'd be great. @azz that's much less of an issue if it's run with Regardless, it's a good point – prettier could be used as a warning instead of an error, though that has it own set of problems (other developers will see changes when they edit the file b/c you didn't run prettier yourself). On a separate note, I'll dig around and see if airbnb might be interested in pulling prettier into their official recommendations (I don't think they are). |
@rattrayalex airbnb is not interested in Prettier: airbnb/javascript#1548 |
For posterity: if prettier can become compatible with airbnb's styleguide, which means that it will allow configuration where we differ, both now and in the future, wherever eslint can not be used afterwards to clean up differences, then airbnb is indeed interested in using prettier. |
So far the adoption we have gotten has been relatively passive with only talks and twitter. We're now at a point where prettier is rock solid and we can recommend it broadly.
What would be nice is to suggest adding prettier as part of the default installation of all the popular js/react/vue/angular/ember boilerplates/cli and helping out those teams with any questions and issues they may have with prettier.
If you are interested in helping out with this effort, that would be awesome :)
The text was updated successfully, but these errors were encountered: