Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please allow users to ignore having Prettier run on settings.json in VS Code #2563

Closed
nikitavoloboev opened this issue Jul 30, 2017 · 7 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Comments

@nikitavoloboev
Copy link

I get this issue every time :

2017-07-30 at 17 26

I know its due to the fact that comments are not allowed in JSON but I need to use them for my personal reference. Please allow ignoring of certain files to be run by prettier. Thank you.

@josephfrazier
Copy link
Collaborator

@azz
Copy link
Member

azz commented Jul 30, 2017

The next release will support .prettierignore, but #2476 should fix this.

@azz azz closed this as completed Jul 30, 2017
@nikitavoloboev
Copy link
Author

Hi @azz

I can't quite understand how to use #2476 to fix this issue. Can you help?

@CiGit
Copy link
Member

CiGit commented Aug 7, 2017

#2476 is not yet released, but it will allow comments in JSON.

In the meantime, if you use prettier-vscode, you can disable prettier on JSON files and use the default formatter provided with VSCode. To do so, add in your settings:
prettier.jsonEnable: []
I just noticed it's missing from our Readme 😕

Edit: Fixed our readme

@telemmaite
Copy link

I have auto generated package.json with comments from ExtJS Sencha CMD,
prettier.jsonEnable: []
This is no longer working!
It tries to parse package.json to discover configuration even though I have .prettierignore and .prettierrc

Error is obvious :
package.json /** ^: JSONError: Unexpected token '/' at 2:5 in

@suchipi
Copy link
Member

suchipi commented Apr 26, 2018

@telemmaite Could you open a separate issue with some more information? Sounds like it's different from this one.

@telemmaite
Copy link

@suchipi I did open the issue here: prettier/prettier-vscode#429

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

6 participants