Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to turn off {' '} tags in JSX #1569

Closed
grydstedt opened this issue May 9, 2017 · 5 comments
Closed

Option to turn off {' '} tags in JSX #1569

grydstedt opened this issue May 9, 2017 · 5 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Comments

@grydstedt
Copy link

We have some localization code that assumes certain html structure is created from JSX. We love prettier but the adding of {' '} inserts unexpected spans in React. Would it be possible to add an option to turn this behavior off? I can try to cook up a PR if so.

@vjeux
Copy link
Contributor

vjeux commented May 9, 2017

Could you try to patch #1120 and see if it fixes your issue? It should put {' '} way less often.

@grydstedt
Copy link
Author

@vjeux thanks! will try that out.

@vjeux
Copy link
Contributor

vjeux commented May 10, 2017

Does it work for your usecase?

@grydstedt
Copy link
Author

grydstedt commented May 10, 2017

It worked cleaning up some of it and for others I just used prettier-ignore. Definitely an improvement though

@vjeux
Copy link
Contributor

vjeux commented May 10, 2017

Cool thanks!

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

2 participants