Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.prettierrc #154

Closed
BLamy opened this issue Jan 12, 2017 · 5 comments
Closed

.prettierrc #154

BLamy opened this issue Jan 12, 2017 · 5 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Comments

@BLamy
Copy link

BLamy commented Jan 12, 2017

I searched and didn't really see anything for this but as prettier gets more configuration options it would be ideal to be able to configure it on a per project basis.

For instance, some projects use trailing commas others don't. Some projects don't use semicolons others may want automatic semicolon insertion.

Seeing a .prettierrc file in the project is probably a good tip off that they expect all code to be formatted with prettier.

@hzoo
Copy link
Contributor

hzoo commented Jan 12, 2017

#40 can cover this in a way if you haven't seen

@vramana
Copy link

vramana commented Jan 12, 2017

@jlongster has confirmed that he is not interested in adding configuration files to prettier. He will soon add FAQ document for this.

@vramana vramana closed this as completed Jan 12, 2017
@brunolemos
Copy link

brunolemos commented Jan 16, 2017

EDIT: Duplicated of #98.

I may be missing something too.
I agree with the not-too-many-config approach, but if this lib already supports some options, why not support a .prettierrc file too? It's not asking to add more configuration, just an easier way to read them.


Where I'm coming from:
I've put the prettier configs in the vscode settings.json.
Later, I run the cli command and did not pass the options in the cli, so it of course changed all my files back to the defaults. I was so used to eslint, babel, etc, looking at config files that I didn't realized the cli command would not use it. :)

@rattrayalex-stripe
Copy link
Contributor

Prettier now has a configuration file.

Docs: https://github.com/prettier/prettier/blob/master/README.md#configuration-file
Release notes: https://github.com/prettier/prettier/releases/tag/1.6.0

@djvs
Copy link

djvs commented May 20, 2018

Updated link for Googlers https://prettier.io/docs/en/configuration.html

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Aug 18, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

6 participants