Update @typescript-eslint/typescript-estree to support satisfies
#13872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachkaev
reviewed
Nov 20, 2022
|
I think we should release 2.8 after this PR is merged without waiting typescript-estree supports auto accessors because most users want to update to TypeScript 4.9 for the |
kachkaev
reviewed
Nov 21, 2022
| @@ -1,10 +1,8 @@ | |||
| #### Support TypeScript 4.9 (#13764, #13783 by @sosukesuzuki) | |||
| #### Support TypeScript 4.9 (#13764, #13783, #13872 by @sosukesuzuki) | |||
There was a problem hiding this comment.
How about this header instead?
Suggested change
| #### Support TypeScript 4.9 (#13764, #13783, #13872 by @sosukesuzuki) | |
| #### Support TypeScript 4.9 `satisfies` operator (#13764, #13783, #13872 by @sosukesuzuki) |
Suggested change
| #### Support TypeScript 4.9 (#13764, #13783, #13872 by @sosukesuzuki) | |
| #### Support TypeScript 4.9 [`satisfies`](https://devblogs.microsoft.com/typescript/announcing-typescript-4-9/#satisfies) operator (#13764, #13783, #13872 by @sosukesuzuki) |
Otherwise we start with an overpromise. Instead of adding a header for Auto-Accessors in Classes we can say something like:
[Auto-Accessors in Classes](https://devblogs.microsoft.com/typescript/announcing-typescript-4-9/#auto-accessors-in-classes) will be supported in an upcoming 2.8 patch release. We have de-scoped them for now to ship `satisfies` operator sooner.
There was a problem hiding this comment.
Isn't it already supported by babel-ts parser? User can switch to use it temporarily.
There was a problem hiding this comment.
@babel/parser can parse auto accessors. But it cannot be used with type annotations to we need to wait babel/babel#15209
fisker
approved these changes
Nov 22, 2022
4 tasks
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Jan 4, 2024
…rettier#13872) * Update to `5.43.1-alpha.22` * Update snapshots for satisfies * Update changelog * Remove `@ts-expect-error` comment * Yarn dedupe * Update to stable version * Fix changelog * Fix changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is still alpha (ref: typescript-eslint/typescript-eslint#5688 (comment)).Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨