Expression expected error on logical operator after checking if instanceof GenericClass<T>

[lucasrabiec]

Prettier 2.7.1
Playground link

--parser typescript

Input:

export class Foo<T> {
}

function sample(error: unknown) {
  if (!(error instanceof Foo<'some-type'> || error instanceof Error) || !error.message) {
    return 'something';
  }
}

Output:

SyntaxError: Expression expected. (5:43)
  3 |
  4 | function sample(error: unknown) {
> 5 |   if (!(error instanceof Foo<'some-type'> || error instanceof Error) || !error.message) {
    |                                           ^
  6 |     return 'something';
  7 |   }
  8 | }

Expected behavior:

  3 |
  4 | function sample(error: unknown) {
  5 |   if (
  6 |     !(error instanceof Foo<'some-type'> || error instanceof Error) ||
  7 |     !error.message
  8 |   ) {
  6 |     return 'something'
  7 |   }
  8 | }

It works if I wrap Foo<'some-type'> with parentheses and then prettier formats it like expected behavior (also removes ( )) but I think it should work without wrapping. edit: problem occured again on reformat (obviously)

It works if I split that logical OR into separate statements (I know this is not logically the same as above, just for an example)

!(error instanceof Foo<'some-type'>) ||
!(error instanceof Error) ||
!error.message

[fisker]

Not sure when it's fixed, but works in main branch.

[lucasrabiec]

@fisker, great! Do you know when it will be released?

[fisker]

Very soon, #13792

[lucasrabiec]

Ok, thank you for the info. I am closing it.

[fisker]

Would like to add a test for it?

[lucasrabiec]

Yes, I can give it a try. Is tests/format/typescript/generic the correct place for that test?

[fisker]

Maybe tests/format/typescript/logical-expression (not-exist yet) is a better place.

[thorn0]

Expressions like Foo<'some-type'> are called instantiation expressions, so the place for the test is tests\format\typescript\instantiation-expression

[fisker]

Reopen to track test.

[lucasrabiec]

@fisker I added test: #13897