Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update description of vueIndentScriptAndStyle option #13781

Merged
merged 3 commits into from Nov 4, 2022
Merged

Update description of vueIndentScriptAndStyle option #13781

merged 3 commits into from Nov 4, 2022

Conversation

fisker
Copy link
Sponsor Member

@fisker fisker commented Nov 2, 2022 •
edited

Description

I think this sentence here may affect people's decision making. And "this might break code folding in your editor" seems outdated. microsoft/vscode#3422

@lydell You suggest this #6157 (comment), WDYT

Note to myself: update stable version if approved.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker mentioned this pull request Nov 2, 2022
Merged
2 tasks
lydell
lydell approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@lydell lydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t mind changing it.

@fisker fisker merged commit ae4d85a into prettier:main Nov 4, 2022
@fisker fisker deleted the vue-indent-script-and-style branch November 4, 2022 03:14
@kachkaev kachkaev added this to the 2.8 milestone Nov 16, 2022
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 4, 2024
@fisker @medikoo
Update description of vueIndentScriptAndStyle option (prettier#13781)
e5e3bff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lydell lydell lydell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fisker @lydell @kachkaev