Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some bundle test code into tests/ #12577

Merged
merged 5 commits into from Apr 2, 2022
Merged

Move some bundle test code into tests/ #12577

merged 5 commits into from Apr 2, 2022

Conversation

fisker
Copy link
Sponsor Member

@fisker fisker commented Apr 1, 2022 •
edited

Description

Those tests added before we have a test for bundles, remove them from build and test setup.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker marked this pull request as ready for review April 1, 2022 09:35
sosukesuzuki
sosukesuzuki approved these changes Apr 2, 2022
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@fisker fisker merged commit afd0220 into prettier:main Apr 2, 2022
@fisker fisker deleted the bundle-test branch April 2, 2022 08:14
sosukesuzuki pushed a commit that referenced this pull request Apr 2, 2022
@fisker @sosukesuzuki
Move some bundle test code into tests/ (#12577)
ca7f062
sosukesuzuki pushed a commit that referenced this pull request Apr 2, 2022
@fisker @sosukesuzuki
Move some bundle test code into tests/ (#12577)
e2eac0c
@sync-by-unito sync-by-unito bot mentioned this pull request May 1, 2022
Closed
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 3, 2024
@fisker @medikoo
Move some bundle test code into tests/ (prettier#12577)
0d8e3d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisker @sosukesuzuki