Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add a plugin to throw unexpected warnings #12463

Merged
merged 2 commits into from Mar 15, 2022

Conversation

fisker
Copy link
Sponsor Member

@fisker fisker commented Mar 15, 2022

Description

Quote from evanw/esbuild#2103 (comment)

Most warnings for files inside node_modules are debug messages instead of warnings. One reason is because the warning isn't immediately actionable, since the person seeing the warning has no way of fixing the problem (only the package author can fix the problem). Another reason is because every time I add a warning that triggers for files inside node_modules, someone ends up filing an issue telling me to remove it. So I have been making them debug messages instead of warnings.

Add a plugin to throw unexpected warnings.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker
Copy link
Sponsor Member Author

fisker commented Mar 15, 2022

I'm going to use this plugin to make sure #12461 is safe to merge.

@fisker fisker merged commit 34dcd96 into prettier:main Mar 15, 2022
@fisker fisker deleted the esbuild-throw-warnnings branch March 15, 2022 14:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant