Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the State of JS Survey Results #12350

Merged
merged 49 commits into from Mar 24, 2022
Merged

Updated the State of JS Survey Results #12350

merged 49 commits into from Mar 24, 2022

Conversation

Harry-Hopkinson
Copy link
Contributor

@Harry-Hopkinson Harry-Hopkinson commented Feb 22, 2022 •
edited

Description

Updated the State of JS Survey Results in order to comply with the 2021 Survey.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker
Copy link
Sponsor Member

fisker commented Feb 22, 2022

Thanks for your contribution. Can you split different changes into seperate PRs?

@Harry-Hopkinson
Copy link
Contributor Author

Sure

@Harry-Hopkinson Harry-Hopkinson changed the title Updated the State of JS Survey Results. Removed unused dependecies with depcheck and infered parameter types from usage. Updated the State of JS Survey Results. Feb 22, 2022
@Harry-Hopkinson
Copy link
Contributor Author

@fisker I have reverted the changes to only have one change.

@thorn0
Copy link
Member

thorn0 commented Feb 22, 2022

@Harry-Hopkinson There are still some links to 2020 left and also old numbers of respondents. Please recheck.

@Harry-Hopkinson
Copy link
Contributor Author

The links should of changed

@thorn0
Copy link
Member

thorn0 commented Feb 22, 2022

Please check again. All the mentions of 2020 should be replaced with 2021 (not 2022).

@Harry-Hopkinson
Copy link
Contributor Author

Ah yes - sorry

thorn0
thorn0 reviewed Feb 22, 2022
View reviewed changes
website/pages/en/index.js Outdated Show resolved Hide resolved
thorn0
thorn0 reviewed Feb 22, 2022
View reviewed changes
changelog_unreleased/javascript/12350.md Outdated
@@ -0,0 +1,2 @@
Updated the State of JS Survey Results in order to comply with the 2021 Survey.
I have removed unused dependecies with depcheck and where applicable, have infered parameter types from usage for type checking. (#12350 by @Harry-Hopkinson)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"JavaScript" isn't the right changelog subdirectory. Turns out we don't yet have a changelog category for this kind of changes. Please add a misc directory (with .gitkeep) in changelog_unreleased and then add it to scripts/draft-blog-post.mjs and scripts/utils/changelog-categories.mjs.

Copy link
Member

@kachkaev kachkaev Feb 23, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have CHANGELOG at all, assuming that the PR is only about docs? I thought CHANGELOG was related to prettier library only.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it might be useful for encouraging non-code contributions like this. Now if someone contributes, for example, to the docs, they won't get any credits at all when the next release happens.

@fisker
Copy link
Sponsor Member

fisker commented Feb 23, 2022

How about keep both data from 2020 and 2021?

@Harry-Hopkinson Harry-Hopkinson changed the title Updated the State of JS Survey Results. Updated the State of JS Survey Results and Changed Zeit.co to Vercel due to its recent name change. Mar 5, 2022
@Harry-Hopkinson
If the number of Unformatted Files is Greater than 2, print out how m…
ad6038e 
…any files there are that do not apply to the Prettier Format Style.
@Harry-Hopkinson Harry-Hopkinson changed the title Updated the State of JS Survey Results and Changed Zeit.co to Vercel due to its recent name change. Updated the State of JS Survey Results, Changed Zeit.co to Vercel due to its recent name change and Print out How Many Unformatted Files do not apply to the Prettier Configuration. Mar 5, 2022
@kachkaev kachkaev self-requested a review March 16, 2022 00:47
fisker
fisker requested changes Mar 22, 2022
View reviewed changes
Copy link
Sponsor Member

@fisker fisker left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you see the diff? They are obviously wrong!

@fisker
Copy link
Sponsor Member

fisker commented Mar 22, 2022 •
edited

IMG_20220322_190811
Isn't this still 2020 version logo? And it should be the same width as the images bellow, maybe also same color.

@Harry-Hopkinson
Copy link
Contributor Author

I have updated the image, just converting it to gray scale.

@Harry-Hopkinson
Copy link
Contributor Author

@fisker that is the State of JS logo for 2021.

@fisker fisker self-assigned this Mar 24, 2022
@fisker
Copy link
Sponsor Member

fisker commented Mar 24, 2022

1648091159(1)
1648091159(2)
1648091159
1648091159(3)

@fisker
Copy link
Sponsor Member

fisker commented Mar 24, 2022

I'm merging this, we are not going to spend more time on reviewing this.

@fisker fisker changed the title Updated the State of JS Survey Results. Updated the State of JS Survey Results Mar 24, 2022
@fisker fisker merged commit 9e7f7b9 into prettier:main Mar 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fisker fisker fisker requested changes

@thorn0 thorn0 Awaiting requested review from thorn0

@kachkaev kachkaev Awaiting requested review from kachkaev

Assignees

@fisker fisker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Harry-Hopkinson @fisker @thorn0 @kachkaev