Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[handlebars] Named blocks can't be self closing #11900

Merged
merged 4 commits into from Dec 2, 2021
Merged

[handlebars] Named blocks can't be self closing #11900

merged 4 commits into from Dec 2, 2021

Conversation

duailibe
Copy link
Member

@duailibe duailibe commented Dec 1, 2021

Description

Closes #11899

Checklist

  • I’ve added tests to confirm my change works.
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.

✨Try the playground for this PR✨

@duailibe duailibe merged commit d3dfb74 into main Dec 2, 2021
@duailibe duailibe deleted the issue-11899 branch December 2, 2021 01:26
@jelhan jelhan mentioned this pull request Dec 2, 2021
Open
sosukesuzuki pushed a commit that referenced this pull request Dec 4, 2021
@duailibe @sosukesuzuki
[handlebars] Named blocks can't be self closing (#11900)
99649c7
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 1, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fisker fisker fisker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Glimmer: Named blocks without content are self-closed on format
2 participants
@duailibe @fisker