Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds more tests for release script #11467

Open
sosukesuzuki opened this issue Sep 8, 2021 · 1 comment
Open

Adds more tests for release script #11467

sosukesuzuki opened this issue Sep 8, 2021 · 1 comment
Assignees
@sosukesuzuki
Labels
type:tests Issues about tests that are not correct, should be added, or similar

Comments

@sosukesuzuki
Copy link
Member

We've added Jest to release script for testing.

Now, we have only test for validate-version step.

We should add more tests for other tests.

But, scripts/release is a pure ESM package. So we cannot use jest.mock.

We need to wait release jestjs/jest#11818
@sosukesuzuki sosukesuzuki added the type:tests Issues about tests that are not correct, should be added, or similar label Sep 8, 2021
@sosukesuzuki sosukesuzuki self-assigned this Sep 8, 2021
@fisker
Copy link
Sponsor Member

fisker commented Sep 8, 2021

Released jestjs/jest#11818 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sosukesuzuki sosukesuzuki

Labels
type:tests Issues about tests that are not correct, should be added, or similar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fisker @sosukesuzuki