Refactor html printer #11462
Merged
Refactor html printer #11462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
reviewed
Sep 7, 2021
src/language-html/print/tag.js
Outdated
| needsToBorrowParentClosingTagStartMarker, | ||
| needsToBorrowPrevClosingTagEndMarker, | ||
| }, | ||
| opening: { |
There was a problem hiding this comment.
I don't like closing and opening, when we move to esm, most likely we'll use named export, why not just put everything on module.exports?
fisker
approved these changes
Sep 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract
printOpening~~,printClosing~~andembed.Does not touch logics.
Checklist
✨Try the playground for this PR✨