Consistently quote Sass modules strings #11461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niksy
force-pushed
the
sass-modules-quotes
branch
from
212f339
to
38e427d
Compare
sosukesuzuki
reviewed
Sep 7, 2021
src/language-css/parser-postcss.js
Outdated
| @@ -525,7 +525,7 @@ function parseNestedCSS(node, options) { | |||
| return node; | |||
| } | |||
|
|
|||
| if (lowercasedName === "import") { | |||
| if (["import", "use", "forward"].includes(lowercasedName)) { | |||
There was a problem hiding this comment.
Could you define a new function as following:
const moduleRuleNames = new Set(["import", "use", "forward"]);
function isModuleRuleName(name) {
return moduleRuleNames.has(name);
}And replace this to
if (isModuleRuleName(lowercasedName)) {?
tests/format/scss/quotes/quotes.scss
Outdated
| @@ -0,0 +1,2 @@ | |||
| @use "module"; | |||
| @forward "module"; | |||
There was a problem hiding this comment.
We need more tests here, because we use parser here and it can break output, please add:
@use 'library' with (
$black: #222,
$border-radius: 0.1rem
);
ideally even more
|
@alexander-akait I’ve added more use cases in tests. |
alexander-akait
approved these changes
Sep 8, 2021
sosukesuzuki
approved these changes
Sep 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11053.
Description
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨