Add tests for release script #11454
Merged
Add tests for release script #11454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
changed the title
sosukesuzuki
force-pushed
the
add-tests-for-release-scripts
branch
from
b6c6b6c
to
3f62b4a
Compare
|
Why |
|
This means |
|
My guess, caused by https://github.com/acornjs/acorn/releases/tag/8.5.0, try regenerate lock file will see the problem. |
sosukesuzuki
force-pushed
the
add-tests-for-release-scripts
branch
from
3f62b4a
to
4224307
Compare
fisker
reviewed
Sep 7, 2021
| cache: "yarn" | ||
|
|
||
| - name: Install Dependencies | ||
| run: cd scripts/release && yarn install --frozen-lockfile |
There was a problem hiding this comment.
Can we use working-directory? https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#defaultsrun
There was a problem hiding this comment.
48fc148 , works fine
fisker
approved these changes
Sep 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for release script.
This PR adds test for one step (
validate-new-version). In other PR, I'll add tests for other steps.Checklist
✨Try the playground for this PR✨