Add a script that generates changelog for patch release #11052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
reviewed
Jun 12, 2021
|
|
||
| function parseArgv() { | ||
| const argv = minimist(process.argv.slice(2)); | ||
| const previousVersion = argv["prev-version"]; |
There was a problem hiding this comment.
Shouldn't previous version always require("prettier").version?
There was a problem hiding this comment.
I think that's correct in most cases. However, the release script actually get the previous version in a different way(ref:
prettier/scripts/release/release.js
Lines 20 to 24 in acf9242
There was a problem hiding this comment.
@fisker What do you think? I want to merge this for next patch version.
- Add ./scripts/changelog-for-patch.mjs - Extract common functions to ./scripts/utils/changelog - Use changelog-for-patch.mjs from release script
sosukesuzuki
force-pushed
the
change-log-script
branch
from
194759f
to
15b112b
Compare
fisker
approved these changes
Jun 26, 2021
Raud-pi
approved these changes
Jun 26, 2021
We call prettier at with prettier/scripts/release/steps/update-changelog.js Lines 80 to 83 in 15b112b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
./scripts/changelog-for-patch.mjs./scripts/utils/changelogchangelog-for-patch.mjsfrom release scriptChecklist
✨Try the playground for this PR✨