Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert features for minor #11016

Merged
merged 1 commit into from Jun 5, 2021

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Jun 5, 2021

Description

I'm now preparing for the 2.3.1 release. Some new feature implementations have already been included in the main branch. These features should be released as minor, not as a patch. So this PR reverts commits that adds these features for now.

I'll revert this PR after the release of 2.3.1.

new features that is reverted by this PR:

Checklist

Try the playground for this PR

@fisker
Copy link
Sponsor Member

fisker commented Jun 5, 2021

__babel_estree is just a internal parser. And the .stylelintrc format can be included IMO.

@sosukesuzuki
Copy link
Member Author

Okay I'll cancel to revert __bable_estree. But about .stylelintrc, it should be released as minor. Because for example a user use prettier . --write, Prettier now formats stylelintrc just after a patch update. Many people will not like this.

@sosukesuzuki sosukesuzuki merged commit 09d65c3 into prettier:main Jun 5, 2021
@sosukesuzuki sosukesuzuki deleted the revert-features-for-minor branch June 5, 2021 09:32
@fisker
Copy link
Sponsor Member

fisker commented Jun 6, 2021

PR to reverse back? We can keep it open for a while.

@fisker
Copy link
Sponsor Member

fisker commented Jun 6, 2021

I don't understand, why don't you use path-release branch?

@sosukesuzuki
Copy link
Member Author

I don't understand, why don't you use path-release branch?

Because there were many commits to be released. I decided that it would be easier to revert these commits once they were done.

@sosukesuzuki
Copy link
Member Author

But however, I do not believe that the method I took was the best. I think there is room for improvement in the flow of the patch release.

@thorn0
Copy link
Member

thorn0 commented Jun 7, 2021

  1. Commit reverts like this and other necessary changes to the patch-release branch
  2. Do a release from that branch
  3. Merge the branch to main

I don't see anything bad about this flow.

update: okay, after thinking more about it. I see that you'd have to revert the revert anyway, so it doesn't matter whether the branch was used. Sorry.

@thorn0
Copy link
Member

thorn0 commented Jun 7, 2021

Looks like using the branch makes sense only if you cherry-pick the changes you want to release.

@fisker
Copy link
Sponsor Member

fisker commented Jun 7, 2021

IMO, we are taking version number too serious. Just release as 2.4.0, not a big deal.

@thorn0
Copy link
Member

thorn0 commented Jun 7, 2021

At some point there was made a decision not to make releases too often (because every update of Prettier in a project leads to reformatting the code base) and focus on their quality instead. I can't find a link though.

fisker added a commit that referenced this pull request Jun 11, 2021
sosukesuzuki pushed a commit that referenced this pull request Aug 31, 2021
sosukesuzuki pushed a commit that referenced this pull request Aug 31, 2021
sosukesuzuki added a commit that referenced this pull request Aug 31, 2021
* Revert "Revert features for minor (#11016)"

This reverts commit 09d65c3.

* Update cspell.json

Co-authored-by: sosukesuzuki <aosukeke@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants