New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make the cli work with/without prettier-eslint
peer
#438
Conversation
prettier-eslint
peer
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 4 +1
Lines 161 163 +2
Branches 27 27
=========================================
+ Hits 161 163 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@JounQin FYI, the release didn't work.
|
That's why I don't like it, I'd prefer Any idea how can I fix? Or can we migrate to changesets? cc @kylemh |
Instead of migrating to |
Take prettier/eslint-plugin-prettier@7bd70b6#diff-8a555112659f40251b1022a16f7f984287f501c43766c71c0bfd2c2f3ef6ffa1R2 as an example. |
Oh damn. I WAS going to say: I'm not at all worried to switch to
That seems silly. Okay, I don't know. Interested to hear what other say. The tool is technically correct. This isn't a major version change, but - in my opinion - versioning is best served as a communication tool with consumers. Making it a strict reference to changes in interface seems like losing out on an opportunity to be really responsible to our users. |
Stupid, actually. 😁
That's the point why I want to migrate to But to make it not a blocker, I'd like to mark a |
I like the non-blocking strategy personally, but will defer to others on that. Alternative to Either works well enough, imo. |
Yep, I'll raise a new PR requesting review later.
I've been using
I'm not so familiar with https://github.com/intuit/auto. |
close #144 BREAKING CHANGE: bump all upgradable (dev)Dependencies except pure ESM
My only concern with making it a peer dependency is that what if we make a breaking change where the CLI only works with |
We can change the version range of peer. |
Oh as for |
Let's skip changesets in this PR and continue at #441 @idahogurl Are we good to merge this PR? |
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What:
close #144, close #436
BREAKING CHANGE: bump all upgradable (dev)Dependencies except pure ESM
(WTF
semantic-release
...)We must be careful on merging...
BREAKING CHANGE:
token must be in the footer of the commit (which is stupid again and again)Why:
close #144
How:
mark
prettier-eslint
as optional peer dependency, and fallback to internal@prettier/eslint
which actually pointing toprettier-eslint