fix(list-different): removed the message at the end of execution #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea why CI didn't run with that merge commit... |
|
Stale pull request |
JounQin
force-pushed
the
fix/list-different
branch
from
3e5ceed
to
5be3feb
Compare
🦋 Changeset detectedLatest commit: 97c9c06 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
JounQin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 165 166 +1
Branches 27 29 +2
=========================================
+ Hits 165 166 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kylemh
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This fixes #111
We want to omit the messages at the end of the execution when the --list-different flag is passed.
Why:
The behavior of
--list-differentis to error out if detects changed files.The
successmessage that follows this is confusing.How:
Simple if/else clause