Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eslint 5 #143

Closed
jingsam opened this issue Nov 14, 2018 · 5 comments
Closed

Support eslint 5 #143

jingsam opened this issue Nov 14, 2018 · 5 comments

Comments

@jingsam
Copy link

jingsam commented Nov 14, 2018

ESlint 5 have released for a period of time, would you considering add support of it?

  • prettier-eslint-cli version:
  • prettier version:
  • eslint version:

Relevant code/config.

What you did:

What happened:

Reproduction:

-- paste your link here --

Problem description:

Suggested solution:

@ryansully
Copy link

There is a deprecation warning that can also be fixed by upgrading to ESLint 5.x.
Details: eslint/eslint#11052

@marcofugaro
Copy link

Any updates?

@zimme
Copy link
Member

zimme commented Jun 12, 2019

Tests are fixed in prettier-eslint now, so work can begin to support eslint 5+, etc.

@zimme
Copy link
Member

zimme commented Jun 17, 2019

Fixed in prettier-eslint-cli@5.0.0 which uses prettier-eslint@9.0.0.

@zimme zimme closed this as completed Jun 17, 2019
@marcofugaro
Copy link

Good job @zimme! I tried out the new beta version, and this warning pops up:

{ parser: "babylon" } is deprecated; we now treat it as { parser: "babel" }.

The command I'm running is prettier-eslint --write src/**/*.{js,jsx,ts,tsx}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants