New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support matching dot files #132
Conversation
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 123 123
Branches 16 16
=====================================
Hits 123 123
Continue to review full report at Codecov.
|
@kentcdodds @zimme |
Stale pull request |
Dot files are excluded by ESLint and prettier by default AFAIK, maybe this new feature should be behind a flag? Or maybe we should respect |
I think this should be implemented under a flag, can |
🦋 Changeset detectedLatest commit: 6415555 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
I think a I can see at least 2 ways:
|
I review the source codes we're using this approach now: https://github.com/prettier/prettier-eslint-cli/blob/master/src/format-files.js#L206-L236 So we'll only need to support a |
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 166 167 +1
Branches 29 29
=========================================
+ Hits 166 167 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I hope it can format and repair all matching files in my project, but I found that it did not format my configuration file (eg: .eslintrc.js, .postcssrc.js, etc.)
https://github.com/isaacs/node-glob#dots