One config to rule them all #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 1, 2021
… errors (#22452) Delete "prettier/@typescript-eslint" from .eslintrc.json. After update to the last version I getting this error on running lint: ESLint couldn't find the config "prettier/@typescript-eslint" to extend from. I explore this issue prettier/eslint-config-prettier#175 and I think those extensions aren't needed anymore.
This was referenced Mar 6, 2021
Closed
Merged
Closed
This was referenced Mar 16, 2021
Merged
Closed
kou029w
added a commit
to npocccties/chibichilo
that referenced
this pull request
Mar 18, 2021
- [use\-debounce@v6.0](https://github.com/xnimorz/use-debounce/releases/tag/6.0) removed callback field, instead of this useDebouncedCallback and useThrottledCallback returns a callable function [make return result callable, get rid of useCallbacks · xnimorz/use\-debounce@045f960](xnimorz/use-debounce@045f960) - https://github.com/prisma/prisma/releases/tag/2.17.0 [feat\(client\): improve transaction arg type by williamluke4 · Pull Request \#5558 · prisma/prisma](prisma/prisma#5558) - https://github.com/prisma/prisma/releases/tag/2.19.0 [Hassle\-Free Database Migrations with Prisma Migrate](https://www.prisma.io/blog/prisma-migrate-ga-b5eno5g08d0b) - https://github.com/kleydon/prisma-session-store/releases/tag/v3.0.0 [expires \-> expiresAt; min express\-session and prisma versions by kleydon · Pull Request \#36 · kleydon/prisma\-session\-store](kleydon/prisma-session-store#36) - ["prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0.](https://github.com/prettier/eslint-config-prettier/blob/v8.1.0/CHANGELOG.md#version-800-2021-02-21) [One config to rule them all by lydell · Pull Request \#175 · prettier/eslint\-config\-prettier](prettier/eslint-config-prettier#175) - [ts-jest@v26.5.3](https://github.com/kulshekhar/ts-jest/blob/v26.5.4/CHANGELOG.md#2653-2021-03-03) [fix: remove \`@types/jest\` from direct dep by ahnpnl · Pull Request \#2416 · kulshekhar/ts\-jest](kulshekhar/ts-jest#2416)
kou029w
added a commit
to npocccties/chibichilo
that referenced
this pull request
Mar 18, 2021
- [use\-debounce@v6.0](https://github.com/xnimorz/use-debounce/releases/tag/6.0) removed callback field, instead of this useDebouncedCallback and useThrottledCallback returns a callable function [make return result callable, get rid of useCallbacks · xnimorz/use\-debounce@045f960](xnimorz/use-debounce@045f960) - https://github.com/prisma/prisma/releases/tag/2.17.0 [feat\(client\): improve transaction arg type by williamluke4 · Pull Request \#5558 · prisma/prisma](prisma/prisma#5558) - https://github.com/prisma/prisma/releases/tag/2.19.0 [Hassle\-Free Database Migrations with Prisma Migrate](https://www.prisma.io/blog/prisma-migrate-ga-b5eno5g08d0b) - https://github.com/kleydon/prisma-session-store/releases/tag/v3.0.0 [expires \-> expiresAt; min express\-session and prisma versions by kleydon · Pull Request \#36 · kleydon/prisma\-session\-store](kleydon/prisma-session-store#36) - ["prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0.](https://github.com/prettier/eslint-config-prettier/blob/v8.1.0/CHANGELOG.md#version-800-2021-02-21) [One config to rule them all by lydell · Pull Request \#175 · prettier/eslint\-config\-prettier](prettier/eslint-config-prettier#175) - [ts-jest@v26.5.3](https://github.com/kulshekhar/ts-jest/blob/v26.5.4/CHANGELOG.md#2653-2021-03-03) [fix: remove \`@types/jest\` from direct dep by ahnpnl · Pull Request \#2416 · kulshekhar/ts\-jest](kulshekhar/ts-jest#2416)
This was referenced Mar 18, 2021
Closed
saihaj
added a commit
to saihaj/graphql-js
that referenced
this pull request
May 30, 2021
@typescript-eslint rules were combined here prettier/eslint-config-prettier#175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173.
This PR combines all configs into one. This means you can just add
"prettier"to"extends"and it’ll disable rules from all plugins without you having to think about which you use!I’ve wanted this behavior from the start, but thought that it wasn’t possible. Turns out I have been wrong the whole time and disabling unknown rules is perfectly fine! There’s even a test for that in ESLint:
https://github.com/eslint/eslint/blob/9d6063add931f0803cae1676d5df307baf114360/tests/lib/linter/linter.js#L1738-L1742
I also check with nzakas on Discord, and got a 👍 about doing this change.
Fixes #174.
The
"prettier/prettier"config is still separate, since only eslint-plugin-prettier users need it. Doing the above change, I either had to write special case code to keep the behavior forprettier/prettier. Instead of doing that, it felt easier to write special case code for #174 instead.The CLI helper tool now only warns about the rules specific to eslint-plugin-prettier, instead of failing with a non-zero exit code. This is similar to how other “special rules” are handled (if only special rules are found, that’s printed but not considered an error). After all, the CLI tool cannot know your decision – if you want to disable the rules because of the potential problems, or if you’d rather live with occasional errors but cleaner code.