Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable @typescript-eslint/comma-spacing #135

Merged
merged 2 commits into from Jan 28, 2020
Merged

Disable @typescript-eslint/comma-spacing #135

merged 2 commits into from Jan 28, 2020

Conversation

ybiquitous
Copy link
Contributor

Fixes #134

@ybiquitous
Copy link
Contributor Author

The CI failure is due to the following error:

$ npm run test:lint-rules --silent
TypeError: sourceCode.isSpaceBetween is not a function
Occurred while linting /tmp/eslint-config-prettier/index.js:1
    at validateCommaSpacing (/tmp/eslint-config-prettier/node_modules/@typescript-eslint/eslint-plugin/dist/rules/comma-spacing.js:88:44)
    at Program:exit.tokensAndComments.forEach (/tmp/eslint-config-prettier/node_modules/@typescript-eslint/eslint-plugin/dist/rules/comma-spacing.js:132:21)
    at Array.forEach (<anonymous>)
    at Program:exit (/tmp/eslint-config-prettier/node_modules/@typescript-eslint/eslint-plugin/dist/rules/comma-spacing.js:126:35)
    at listeners.(anonymous function).forEach.listener (/tmp/eslint-config-prettier/node_modules/eslint/lib/linter/safe-emitter.js:45:58)
    at Array.forEach (<anonymous>)
    at Object.emit (/tmp/eslint-config-prettier/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/tmp/eslint-config-prettier/node_modules/eslint/lib/linter/node-event-generator.js:254:26)
    at NodeEventGenerator.applySelectors (/tmp/eslint-config-prettier/node_modules/eslint/lib/linter/node-event-generator.js:283:22)
    at NodeEventGenerator.leaveNode (/tmp/eslint-config-prettier/node_modules/eslint/lib/linter/node-event-generator.js:306:14)

@ybiquitous
Copy link
Contributor Author

isSpaceBetween() has been added in ESLint 6.7.2:

eslint/eslint@bc435a9

So, we should bump up our ESLint version:

"eslint": "6.6.0",

@ybiquitous
Copy link
Contributor Author

I've opened PR #136. This PR will work after we will merge PR #136.

lydell pushed a commit that referenced this pull request Jan 28, 2020
@lydell lydell marked this pull request as ready for review January 28, 2020 07:07
@ybiquitous
Copy link
Contributor Author

ybiquitous commented Jan 28, 2020

@lydell Thanks for your merging #136! CI passed expectedly! 🎉

@lydell lydell merged commit 04c79bf into prettier:master Jan 28, 2020
@ybiquitous ybiquitous deleted the disable-typescript-eslint-comma-spacing branch January 28, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn off @typescript-eslint/comma-spacing
2 participants