Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger Mass Assignment rule on other foreign keys than account_id #1685

Open
Owpac-doctolib opened this issue Feb 21, 2022 · 1 comment
Open

Comments

@Owpac-doctolib
Copy link

Is your feature request related to a problem? Please describe.
In order to improve IDOR prevention, it would be interesting to be able to add foreign keys that could trigger warnings from the mass assignment rule.

Describe the solution you'd like
One way to solve it would be to introduce a new flag, e.g. --mass-assignment-match customer_id, role_id, card_id
This way, whenever there is params.permit(:customer_id) or params.permit(:role_id) it will also trigger a warning as for account_id.

@nikolai-b
Copy link

#1144 has some background about when checking all *_id was tried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants