Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions report doesn't show where the error/warning occurs #1666

Open
altjx opened this issue Dec 30, 2021 · 0 comments
Open

GitHub Actions report doesn't show where the error/warning occurs #1666

altjx opened this issue Dec 30, 2021 · 0 comments

Comments

@altjx
Copy link

altjx commented Dec 30, 2021

Background

Brakeman version: 5.2.0
Rails version: 6.1.4.4
Ruby Version: 3.0.2
Link to Rails application code: ?

Issue

RE: #1580

The github output format does not display where the error is when it's being displayed inside of a GitHub Actions workflow. Using the exact same command, the output in the terminal shows completely different.

The below example is how it looks from the terminal output

# root@bf29b8edfeea:/home/ubuntu/myapp# bin/bundle exec brakeman --format github --no-pager

Checks finished, collecting results...
Generating report...
::warning file=app/controllers//XYZ_controller.rb,line=206::Possible command injection
::warning file=lib/custom/slack.rb,line=75::Possible command injection

But from GitHub, it looks like this instead:

Screen Shot 2021-12-30 at 12 28 43 AM

The command that was used to run it from the GitHub Actions is this:

      - name: Brakeman Static Analysis Check
        run: |
          git fetch
          bin/bundle exec brakeman --format github --no-pager

Same command, but different outputs.

@altjx altjx changed the title GitHub Actions report doesn't show error line GitHub Actions report doesn't show where the error/warning occurs Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant