Revert "refactor: IgnoreConfig uses FilePath" #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 52bfc9b. It seems that this might break --interactive-ignore. Specifically on line 39 of lib/brakeman/report/interactive.rb. https://github.com/presidentbeef/brakeman/blob/53db6f585679f648ce761421a9eba2e02e18a4a1/lib/brakeman/report/ignore/interactive.rb#L39 When asking for the ignore file location `@ignore_config.file` is checked for emptiness but Brakeman::FilePath has no `empty?` method and so this fails.
|
@presidentbeef just in case this is useful. Understand if you'd prefer to roll-forward. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 52bfc9b.
It seems that this might break --interactive-ignore. Specifically on
line 39 of lib/brakeman/report/interactive.rb.
brakeman/lib/brakeman/report/ignore/interactive.rb
Line 39 in 53db6f5
When asking for the ignore file location
@ignore_config.fileischecked for emptiness but Brakeman::FilePath has no
empty?method andso this fails.