Freeze call index results #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to prevent modification which is not thread-safe across checks
presidentbeef
force-pushed
the
stop_modifying_results
branch
from
d584de7
to
86b923c
Compare
Repository owner
locked and limited conversation to collaborators
Jan 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent some modification of call index results (matching call sites) which is not thread-safe across checks.
Also, I think this duping of calls in
CheckContentTag,CheckLinkTo, andCheckLinkToHrefis outdated. All these checks subclassCheckCrossSiteScriptingwhich I think used to modify results in some way but as far as I can tell this no longer happens.