Fix flaky rails4 test #1419
Merged
Fix flaky rails4 test #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙇♂️ 🙇♂️ 🙇♂️ Thank you!! |
Repository owner
locked and limited conversation to collaborators
Jan 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #1409
I found the failing seed with:
while rake; do :; doneFailure can be reproduced with
rake TESTOPTS="--seed=42281"The cause is that the
test_external_checkstest is run first, soreporthasn't been called yet. The result is thatBrakeman::CheckExternalCheckTestisn't loaded yet, so thedefined?assertion fails. Simply moving that assertion to after callingreportfixes the test.