New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch reverse tabnabbing with :_blank symbol #1411

Merged

presidentbeef merged 1 commit into presidentbeef:master from JacobEvelyn:master

Oct 22, 2019

Contributor

JacobEvelyn commented Oct 17, 2019

Using target: :_blank in ERB and Haml also results in target="_blank" in HTML, so our reverse tabnabbing check should catch this case too.


          Catch reverse-tabnabbing with :_blank symbol

3f5d5d5

presidentbeef merged commit da1cd50 into presidentbeef:master

Owner

presidentbeef commented Oct 22, 2019

Thanks!

Repository owner locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.