Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgcolor (and probably others) should probably not be inlined #413

Open
dorianmariecom opened this issue Dec 15, 2021 · 2 comments
Open

bgcolor (and probably others) should probably not be inlined #413

dorianmariecom opened this issue Dec 15, 2021 · 2 comments

Comments

@dorianmariecom
Copy link

See for instance: https://www.litmus.com/blog/background-colors-html-email/

Screenshot 2021-12-15 at 13 06 30

background-color and background CSS properties are better supported now than bgcolor

I know there is the css_to_attributes setting, and that's what I'm using now but I think that should be the default and maybe have attribute inlining disabled

see RELATED_ATTRIBUTES in lib/premailer/premailer.rb

@dorianmariecom
Copy link
Author

e.g for instance with tailwind, background-color: rgb(255 255 255 / 1) makes the background green

@grosser
Copy link
Contributor

grosser commented Dec 15, 2021

agree in general, would be open to either being very selective about what to use (for example only doing 6 digit hex) or removing altogether
... depends on how much messier this makes the code and how many end-users it will break :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants