Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nokogumbo has been merged into Nokogiri #408

Closed
dark-panda opened this issue Aug 10, 2021 · 2 comments
Closed

Nokogumbo has been merged into Nokogiri #408

dark-panda opened this issue Aug 10, 2021 · 2 comments

Comments

@dark-panda
Copy link

Nokogumbo has been merged into Nokogiri, so an explicit require for nokogumbo is no longer required in the Nokogumbo adapter.

See sparklemotion/nokogiri#2204 for details.

In my project, I removed the Nokogumbo gem from the Gemfile and got errors about not being able to find nokogumbo.rb. Adding an empty nokogumbo.rb file did the trick, but perhaps the explicit require should be removed from the adapter file?

@fukayatsu
Copy link

Done by #416 ?

@grosser
Copy link
Contributor

grosser commented Oct 19, 2023

looks like it, thx

@grosser grosser closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants