Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined method `create_element' for #<Nokogiri::HTML5::DocumentFragment:0x0055a68d62d9a8> #371

Open
jherdman opened this issue Dec 19, 2018 · 8 comments

Comments

@jherdman
Copy link

When using Nokogiri 1.9.1 and Nokogumbo 2.0.1, the following error comes out of some of our templates:

      NoMethodError:
        undefined method `create_element' for #<Nokogiri::HTML5::DocumentFragment:0x00564bbaaf74c0>
        Did you mean?  create_external_subset

Looking a little into the stack trace we see:

from /home/vagrant/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/premailer-1.11.1/lib/premailer/adapter/nokogumbo.rb:157:in `write_unmergable_css_rules'

Hopefully more data to come...

@jherdman
Copy link
Author

OK, I've found the bug. I'll be sending up a PR shortly.

@utkarsh2102
Copy link

@jherdman, any update?

@jherdman
Copy link
Author

@utkarsh2102 I tried fixing this but failed pretty hard. Ultimately we bailed on this project in favour of roadie.

@utkarsh2102
Copy link

Ah.
@jherdman we'd need this gem for premailer-rails, which is needed by gitlab.
And there are multiple test failures.
D'you have time to look into them? :(

@jherdman
Copy link
Author

Alas, I'm merely a humble dev in the same boat as you. I have no authority on this project. Best of luck!

@meowsus
Copy link
Collaborator

meowsus commented Sep 19, 2019

@utkarsh2102 @jherdman we just did some sprucing up of the master branch, including bumping the versions of all of our dependencies. Would either of you mind pointing your projects at premailer:master to see if this issue is now resolved?

@jherdman
Copy link
Author

Hey @meowsus !

I sadly won't be able to help. We bailed on Premailer for Roadie. Best of luck!

@meowsus
Copy link
Collaborator

meowsus commented Sep 19, 2019

@jherdman I figured as much, but thanks for your response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants