css content dumped into style tag after premailer compile #334

slucaskim · 2017-01-18T16:26:48Z

Is there any reason why the following html:

...
<head>
    <meta content="charset=utf-8"/>
    <%= stylesheet_link_tag "url" %>
</head>
...

should result in this after premailer performs to_inline_css?

...
<style type="text/css">
@-webkit-keyframes panel-slide-up {

}
@keyframes panel-slide-up {

}
...
</style>
...

Premailer inlines all the relevant css correctly, but also creates a huge style tag with irrelevant css from the original stylesheet. This is causing a problem for me as the resulting html becomes too big and email clients clip the message.

In what cases does Premailer create a style tag?

I am using all default configuration settings, so options like "include_style_tags" is false.

The text was updated successfully, but these errors were encountered:

Premailer very happily generates email with thousands of unnecessary lines in the inline <style> tag, which means that at some point, some email clients (particularly Gmail) will refuse to render the email, and will instead clip the email with "[Message clipped] View entire message". It seems this clip is around ~100 KB of inline <style> tags. This new config option, :drop_inline_style_tags, will take the generated `to_inline_css`, and drop the <style> tag completely. In theory, this shouldn't have any impact, beacuse all of the relevant CSS will have been applied to the elements themselves anyway. Resolves issues such as: - premailer/premailer#334 - fphilipe#192 - fphilipe#184

Premailer very happily generates email with thousands of unnecessary lines in the inline <style> tag, which means that at some point, some email clients (particularly Gmail) will refuse to render the email, and will instead clip the email with "[Message clipped] View entire message". It seems this clip is around ~100 KB of inline <style> tags. This new config option, :drop_inline_style_tags, will take the generated `to_inline_css`, and drop the <style> tag completely. In theory, this shouldn't have any impact, because all of the relevant CSS will have been applied to the elements themselves anyway. Resolves issues such as: - premailer/premailer#334 - fphilipe#192 - fphilipe#184

soundasleep · 2018-10-17T05:27:49Z

I've tried to resolve this in the premailer-rails gem (which uses premailer) with a new config option: fphilipe/premailer-rails#227

bborn · 2019-04-17T14:59:38Z

Here you go: #374

soundasleep mentioned this issue Oct 17, 2018

Add :drop_inline_style_tags config option fphilipe/premailer-rails#227

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

css content dumped into style tag after premailer compile #334

css content dumped into style tag after premailer compile #334

slucaskim commented Jan 18, 2017 •

edited

soundasleep commented Oct 17, 2018

bborn commented Apr 17, 2019

css content dumped into style tag after premailer compile #334

css content dumped into style tag after premailer compile #334

Comments

slucaskim commented Jan 18, 2017 • edited

soundasleep commented Oct 17, 2018

bborn commented Apr 17, 2019

slucaskim commented Jan 18, 2017 •

edited