Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse error on IDENT 'deg' #325

Open
keysen opened this issue Nov 2, 2016 · 4 comments
Open

parse error on IDENT 'deg' #325

keysen opened this issue Nov 2, 2016 · 4 comments

Comments

@keysen
Copy link

keysen commented Nov 2, 2016 •
edited

Hello,

It seems when I'm trying to inline the following html:

<body>
<title>20/20 Vision Formula</title>
<style>-webkit-transform:rotate(90deg);-moz-transform:rotate(90deg);p { background-color: red; font-weight: bold; }</style>
<p align="left">His video might be taken down at anymoment.</p>
<p>Restore your 20/20 vision starting today. It's all one click away.</p>
</body>

Premailer raises an error with "parse error on IDENT 'deg'", is it an expected behavior?

I'm not sure Premailer should stop its css inlining when there is something he can't understand, it's probably safer to skip this one and continue to the next css tag, no?

Because in my case, I can't inline a huge html just because one tag or two are fucked up.
@akzhan
Copy link
Member

akzhan commented Feb 23, 2017

@grosser looks like css_parser trouble, isn't it?

@grosser
Copy link
Contributor

grosser commented Feb 23, 2017

hmmm ignoring unknown things sure would make it more stable ... but also means it's harder to find bugs and we would not get backtraces ...
So depending on the usecase someone would want to always blow up (use different styles if necessary) ... and others would want 'best-effort' ... so maybe add a config option to say 'ignore_errors' ?

@akzhan
Copy link
Member

akzhan commented Feb 23, 2017 •
edited

Yes, I suppose that it should be an option.

But deg, grad, rad and turn are known things for HTML transforms for years. And, of course, related to float numbers too.

@grosser
Copy link
Contributor

grosser commented Feb 23, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grosser @akzhan @keysen