Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premailer-specific CSS unexpected result #285

Open
TanKucukhas opened this issue Feb 8, 2016 · 3 comments
Open

Premailer-specific CSS unexpected result #285

TanKucukhas opened this issue Feb 8, 2016 · 3 comments

Comments

@TanKucukhas
Copy link

I'm testing out some css attributes and it looks like premailer creates some unwanted code in the output

example:
table { -premailer-cellspacing: 0; -premailer-cellpadding: 0; -premailer-width: 0; -premailer-height: 0; }
output:
<table style="-premailer-cellspacing: 0; -premailer-cellpadding: 0; -premailer-width: 0; -premailer-height: 0;" width="0" height="0" cellpadding="0" cellspacing="0"></table>

this does not hurt but it looks ugly on the source code. I had to create additional task to clean it after using premailer.

also that would be a lot nicer of premailer support more html attributes instead only 5. Stuff likevalign, border, bgcolor that I use all the time on emails. Not really understand the logic of limiting it to only 5 attributes.

@TanKucukhas TanKucukhas changed the title CSS Attributes Premailer-specific CSS unexpected result Feb 8, 2016
@developer-collin
Copy link

@TanKucukhas I believe this issue has been fixed. I had the exact same issue and fixed it by simply updating my version of premailer.

In my case, I had the issue in premailer version 1.8.4. I just updated to 1.10.0 and the issue went away. Hope that helps.

@akzhan
Copy link
Member

akzhan commented Feb 25, 2017

@TanKucukhas can you check for premailer 1.10.0 behaviour?

Please provide proof of concept (case) if behaviour is same.

I'll review.

@akzhan
Copy link
Member

akzhan commented Feb 25, 2017

Additional attributes to recognize - will do.

But please write a list of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants