Oga Adapter

[bryanp]

Hello! We're trying to remove Nokogiri as a dependency in Pakyow (using Oga instead). The problem is that our mailer lib uses Premailer, which is currently setup to use the Nokogiri adapter. To use Oga throughout the project we'd like contribute an appropriate Premailer adapter.

Has this been attempted? If not, any tips before getting started?

[akzhan]

You can replace Nokogiri with Nokogumbo one.Release with this option will be shortly.

[akzhan]

Or you can provide Oga adapter to be merged into Premailer.

[bryanp]

@akzhan Unfortunately the adapter interface is incredibly tied to Nokogiri (or libraries like Nokogumbo that follow its interface). We made it work in pakyow, but it's not something I'd want to see in Premailer as-is. Doing it correctly would be a larger effort of redesigning the adapter interface. Willing to help, but is redesigning things at this level something that you all are open to doing?

[akzhan]

Yes, any good contribution that did project better will be landed

Вт, 28 июня 2016 г. в 0:59, Bryan Powell notifications@github.com:

@akzhan https://github.com/akzhan Unfortunately the adapter interface
is incredibly tied to Nokogiri (or libraries like Nokogumbo that follow its
interface). We made it work in pakyow, but it's not something I'd want to
see in Premailer as-is. Doing it correctly would be a larger effort of
redesigning the adapter interface. Willing to help, but is redesigning
things at this level something that you all are open to doing?