Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Same property with diferent size units #83

Open
marocas opened this issue Feb 22, 2017 · 3 comments
Open

[QUESTION] Same property with diferent size units #83

marocas opened this issue Feb 22, 2017 · 3 comments

Comments

@marocas
Copy link

marocas commented Feb 22, 2017

Hello, im starting to use rem instead of px, and i found that with premailer, the style inline only goes with rem units, is there a way to have the fallback to px on the inline version, since some emails like outlook don't use rem?

Exemple:
h1{
font-size:32px;
font-size:3.2rem;
}

It only uses the font-size: 3.2rem, it would be good to use both.

#305

Thanks in advance,
Mário Silva.

@marocas
Copy link
Author

marocas commented Aug 8, 2018

Any development on this question?

@grosser
Copy link
Contributor

grosser commented Aug 8, 2018

can try pinging someone who worked on areas around rems if there are any ... or dive into the code to see how it's handled

@marocas
Copy link
Author

marocas commented Aug 9, 2018

In fact, every property that can have multiple units, can have the fallback to px.
Saying this:

font-size: 0px;
font-size: 0em;
font-size: 0rem;
font-size: 0pt;

line-height: 0px;
line-height: 0em;
line-height: 0rem;
line-height: 0pt;

padding: 0px;
padding: 0em;
padding: 0rem;
padding: 0pt;

margin: 0px;
margin: 0em;
margin: 0rem;
margin: 0pt;

I don't know ruby, I already been looking to the code but still didn't find the place where equal keys are striped out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants