Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Regexp::new 3rd argument into 2nd #134

Merged
merged 1 commit into from Dec 29, 2022
Merged

Move Regexp::new 3rd argument into 2nd #134

merged 1 commit into from Dec 29, 2022

Conversation

jacquesn
Copy link

Closes #133

Use of the third argument for Regexp::new is deprecated in Ruby 3.2.0.

Copy link
Contributor

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thx!

@grosser grosser merged commit 234eed2 into premailer:master Dec 29, 2022
@jacquesn jacquesn deleted the regexp-new-third-arg branch December 29, 2022 21:02
@grosser
Copy link
Contributor

grosser commented Dec 29, 2022

FYI 3 tests are failing on 3.2 ... nothing too big, but there might be some trouble #135

@grosser
Copy link
Contributor

grosser commented Dec 29, 2022

1.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3rd argument to Regexp.new is deprecated
3 participants