Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module/nomodule output #60

Closed
developit opened this issue Jul 11, 2020 · 2 comments · Fixed by #196
Closed

Module/nomodule output #60

developit opened this issue Jul 11, 2020 · 2 comments · Fixed by #196
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed plugins reliability
Projects
Milestone

Comments

@developit
Copy link
Member

It is now possible to use multiple outputs (but the same rollup compilation) to generate bundles with different manualChunks option.

Also enabled for multi-output in rollup/rollup#3645, the inlineDynamicImports option might make it easy for us to generate an ssr-bundle.js quickly without adding much overhead to prod builds.

@developit developit added the enhancement New feature or request label Jul 11, 2020
@developit developit added this to To do in 1.0 Jul 16, 2020
@developit developit moved this from To do to In progress in 1.0 Aug 24, 2020
@developit
Copy link
Member Author

I implemented this in one of the test fixtures. We can extract it to packages/ and publish:
https://github.com/developit/wmr/blob/1b008a9916c6cee21169946fdc0b5628f294099e/test/fixtures/config/wmr.config.js#L9

@developit developit added good first issue Good for newcomers help wanted Extra attention is needed reliability plugins labels Nov 29, 2020
@developit developit pinned this issue Nov 29, 2020
@developit developit added this to the 1.0 milestone Nov 29, 2020
@developit
Copy link
Member Author

An initial implementation has been published as a plugin in #196:

// npm install @wmr-plugins/nomodule

import nomodule from '@wmr-plugins/nomodule';
export function build(config) {
  nomodule(config);
}

1.0 automation moved this from In progress to Done Dec 2, 2020
@developit developit linked a pull request Dec 2, 2020 that will close this issue
@developit developit unpinned this issue Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed plugins reliability
Projects
No open projects
1.0
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant