Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox validation triggers on input component render #972

Closed
sandgraham opened this issue Jan 4, 2018 · 4 comments
Closed

Firefox validation triggers on input component render #972

sandgraham opened this issue Jan 4, 2018 · 4 comments
Labels

Comments

@sandgraham
Copy link

Hi, I noticed that on Firefox, any form inputs that are required are immediately validated. This results in the inputs having a red error outline on page load. I ran into this on Preact v8.1.0 and Firefox v58.0b10.

It looks like React recently fixed this: facebook/react#8395. The issue seems well documented in the thread. I might be able to poke around this weekend to offer assistance, but I just wanted to bring this up.

Thanks!

@developit
Copy link
Member

Sorry for the late reply - this is interesting! I'd be happy to discuss if you want to jump on Slack.

@developit developit added the bug label Feb 23, 2018
@Rafi993
Copy link
Contributor

Rafi993 commented Nov 23, 2019

Does this bug still exist. If so I would be willing to help.

@sandgraham
Copy link
Author

I don't think this is still an issue. I tested the behavior out on the latest Firefox Developer Edition 71.0b12 (64-bit) and input does not validate until the form is submitted.

Here is a sandbox to verify: https://codesandbox.io/s/kind-firefly-6fbcx

@JoviDeCroock
Copy link
Member

Great to hear that and thank you for digging up this issue @Rafi993 will close this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants