-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Ensure both onchange and oninput callbacks are executes when typing #3562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
0875c02
to
4d61446
Compare
c186fac
to
08aa27a
Compare
8160863
to
46ddd15
Compare
It looks like a lot of tests have stopped running 😅 trying to figure out how that is possible. the issue with size is fixed here #3563 |
00fc4e4
to
bf20ed5
Compare
7e896b0
to
bed76e8
Compare
bed76e8
to
acfb16d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the back and forth and congratulations on your first PR ❤️
Since this change the
onChange
prop gets normalized tooninput
but this is overwritten if we include theonInput
prop, being only triggered the last one defined.FWIW it's impossible to prevent this prop from being overwritten because we're using it as an object key. In this case, we mimic the React behavior by combing both callbacks in only one.
Fixes #3561